Repository navigation
Seven new net-ssh advisories - #1272
Merged
Merged
Conversation
connorshea
reviewed
Oct 24, 2026
connorshea
reviewed
Oct 24, 2026
simi
reviewed
Oct 26, 2026
simi
reviewed
Oct 26, 2026
flavorjones
reviewed
Oct 26, 2026
flavorjones
left a comment
flavorjones
left a comment
Member
There was a problem hiding this comment.
The 7.3 entries in patched_versions can't match any version. Requirements separated by a comma must all hold, and no version is both ~> 7.3.5 (below 7.4) and >= 7.4.0. As written, bundler-audit reports net-ssh 7.3.5 through 7.3.8 as vulnerable to all seven advisories.
I've suggested "~> 7.3, >= 7.3.5" on each file (>= 7.3.4 for GHSA-vxj5), following activeadmin CVE-2024-37031. That also covers a future 7.4.x and still flags the vulnerable 8.0.0 prereleases. With the suggestions applied, bundler-audit reports 7.3.5, 7.3.8, 8.0.0.rc2 and 8.0.4 as clean, and 7.3.3, 7.3.4 and 8.0.0.beta3 as vulnerable, which matches the GitHub advisories.
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Member
Author
|
Ready for re-Review |
Member
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven new net-ssh advisories